[PATCH] D51611: Set console mode when -fansi-escape-codes is enabled
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 4 11:01:14 PDT 2018
zturner added inline comments.
================
Comment at: lib/Support/Windows/Process.inc:332
+ if (enable) {
+ HANDLE hConsole = GetStdHandle(STD_OUTPUT_HANDLE);
+ DWORD consoleMode;
----------------
We don't use hungarian notation. Also all variables begin with capital letters.
```
HANDLE Console = GetStdHandle(STD_OUTPUT_HANDLE);
DWORD Mode;
GetConsoleMode(Console, &Mode);
Mode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
SetConsoleMode(Console, Mode).
```
https://reviews.llvm.org/D51611
More information about the llvm-commits
mailing list