[PATCH] D51571: [Xray] Darwin providing defined value for weak symbols to fix linkage issue

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added a comment.

The comment is too vague and distracting, please change the comment to something like this:

  // HACK: This is a temporary workaround to make XRay build on Darwin, but it will probably not work at runtime.



================
Comment at: lib/xray/xray_init.cc:38
+// particular issue.
+const XRaySledEntry __start_xray_instr_map[] = {};
+extern const XRaySledEntry __stop_xray_instr_map[] = {};
----------------
why is this one not "extern"?


https://reviews.llvm.org/D51571