[PATCH] D51571: [Xray] Darwin providing defined value for weak symbols to fix linkage issue

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 10:30:14 PDT 2018


kubamracek added a comment.

Hi, as Dean says, this isn't really going to make XRay work, but we need to resolve the buildbot failure soon. FYI, here's the bot failure link: http://green.lab.llvm.org/green/job/lnt-test-suite-x86_64-O3-flto/4486/. It appears that these tests (from MicroBenchmarks/XRay) haven't been previously run on Darwin, but now they are and they're failing. We need to either disable the tests, but if that's problematic, I think I'd be fine with this patch as well to fix the immediate failure, but please add a comment that this is a workaround/hack to get XRay to build on Darwin.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51571





More information about the llvm-commits mailing list