[PATCH] D50591: [PGO] Control Height Reduction

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 10:01:31 PDT 2018


yamauchi marked an inline comment as done.
yamauchi added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:494
 
+  if (EnableCHR && Level == O3 && PGOOpt && !PGOOpt->ProfileUseFile.empty())
+    FPM.addPass(ControlHeightReductionPass());
----------------
davidxl wrote:
> davidxl wrote:
> > How about SamplePGO ?
> In thinLTO mode, you may want to only do this in the backend compilation, otherwise, there is a risk that that fallback path gets CHRed again which is not desirable.
Will look into this later.


Repository:
  rL LLVM

https://reviews.llvm.org/D50591





More information about the llvm-commits mailing list