[PATCH] D51640: [DebugInfo] Normalize common kinds of DWARF sub-expressions.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Can you add a testcase for the 0xffffffff case?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:186
+   emitOp(dwarf::DW_OP_lit0 + Value);
+  else if (Value == 0xfffffff) {
+   emitOp(dwarf::DW_OP_lit0);
----------------
1. This is short one `f`.
2. I'd use some form of uint_max or `~0ULL` so this isn't an issue ;-)


Repository:
  rL LLVM

https://reviews.llvm.org/D51640