[llvm] r341379 - [MachO] Fix inconsistency between error messages when validating LC_DYSYMTAB

Francis Visoiu Mistrih via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 09:31:53 PDT 2018


Author: thegameg
Date: Tue Sep  4 09:31:53 2018
New Revision: 341379

URL: http://llvm.org/viewvc/llvm-project?rev=341379&view=rev
Log:
[MachO] Fix inconsistency between error messages when validating LC_DYSYMTAB

Modified:
    llvm/trunk/lib/Object/MachOObjectFile.cpp
    llvm/trunk/test/tools/llvm-objdump/macho-bad-dysymtab.test

Modified: llvm/trunk/lib/Object/MachOObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/MachOObjectFile.cpp?rev=341379&r1=341378&r2=341379&view=diff
==============================================================================
--- llvm/trunk/lib/Object/MachOObjectFile.cpp (original)
+++ llvm/trunk/lib/Object/MachOObjectFile.cpp Tue Sep  4 09:31:53 2018
@@ -1593,7 +1593,7 @@ MachOObjectFile::MachOObjectFile(MemoryB
       return;
     }
     if (Dysymtab.nextdefsym != 0 && Dysymtab.iextdefsym > Symtab.nsyms) {
-      Err = malformedError("nextdefsym in LC_DYSYMTAB load command "
+      Err = malformedError("iextdefsym in LC_DYSYMTAB load command "
                            "extends past the end of the symbol table");
       return;
     }
@@ -1606,7 +1606,7 @@ MachOObjectFile::MachOObjectFile(MemoryB
       return;
     }
     if (Dysymtab.nundefsym != 0 && Dysymtab.iundefsym > Symtab.nsyms) {
-      Err = malformedError("nundefsym in LC_DYSYMTAB load command "
+      Err = malformedError("iundefsym in LC_DYSYMTAB load command "
                            "extends past the end of the symbol table");
       return;
     }

Modified: llvm/trunk/test/tools/llvm-objdump/macho-bad-dysymtab.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/macho-bad-dysymtab.test?rev=341379&r1=341378&r2=341379&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-objdump/macho-bad-dysymtab.test (original)
+++ llvm/trunk/test/tools/llvm-objdump/macho-bad-dysymtab.test Tue Sep  4 09:31:53 2018
@@ -23,7 +23,7 @@ LoadCommands:
     ilocalsym:       0
     nlocalsym:       0
     iextdefsym:      4
-#CHECK: truncated or malformed object (nextdefsym in LC_DYSYMTAB load command extends past the end of the symbol table)
+#CHECK: truncated or malformed object (iextdefsym in LC_DYSYMTAB load command extends past the end of the symbol table)
     nextdefsym:      2
     iundefsym:       2
     nundefsym:       1




More information about the llvm-commits mailing list