[PATCH] D51593: [dwarfdump] Improve -diff option by hiding more.

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 4 09:03:25 PDT 2018


JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp:410
         while (DataPtr < EndDataPtr) {
-          OS << format("%2.2x ", *DataPtr);
+          AddrOS << format("%2.2x ", *DataPtr);
           ++DataPtr;
----------------
aprantl wrote:
> Can using two different streams cause the output to go out of sync due to buffering?
It's either the same stream or null, so shouldn't pose a problem.


Repository:
  rL LLVM

https://reviews.llvm.org/D51593





More information about the llvm-commits mailing list