[PATCH] D51443: [dsymutil] Remove non-determinism.
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 4 08:37:51 PDT 2018
aprantl added inline comments.
================
Comment at: llvm/tools/dsymutil/DwarfLinker.cpp:318
+ Info.Prune &= Info.Ctxt && Info.Ctxt->getCanonicalDIEOffset() > 0 &&
+ Info.Ctxt->getCanonicalDIEOffset() <= DefinitionOffset;
----------------
This sounds like it would make the resulting .dSYM larger as it now may contain redundant definitions. Is that difference measurable?
Also, we should add a comment here that explains this new behavior.
https://reviews.llvm.org/D51443
More information about the llvm-commits
mailing list