[PATCH] D50783: [CodeGen] Merge identical block descriptor global variables

[David Chisnall via Phabricator via llvm-commits]

theraven added a comment.

In https://reviews.llvm.org/D50783#1221147, @ahatanak wrote:

> The GNUstep documentation I found replaces '@' with '\1'. Would that fix the problem?
>
> https://github.com/gnustep/libobjc2/blob/master/ABIDoc/abi.tex


Yup.  If this mangling is needed outside of CGObjCGNU, it would be good to take the code that does this mangling and move it somewhere that can be reused.  I don't know if there are any characters that are valid in Objective-C type encoding but aren't valid in Windows PE/COFF symbols, but having a hook to fix them in a single place sounds like a good idea.


Repository:
  rC Clang

https://reviews.llvm.org/D50783