[PATCH] D51317: Handle BumpPtrAllocator::Allocate(0) without undefined behavior
    Dávid Bolvanský via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Sep  4 02:33:46 PDT 2018
    
    
  
xbolva00 added a comment.
In https://reviews.llvm.org/D51317#1222631, @hans wrote:
> In https://reviews.llvm.org/D51317#1221692, @brentdax wrote:
>
> > @hans So do you think it's okay to go at this point, or do you want more benchmarking?
>
>
> I'd like to see some kind of benchmark to verify this doesn't have negative performance impact.
Even not so old GCC 7.3 leaves null checks there.. And since we have v4.9 (or so) as a GCC minimum supported version to build LLVM, I think we should avoid this change for now.
Repository:
  rL LLVM
https://reviews.llvm.org/D51317
    
    
More information about the llvm-commits
mailing list