[PATCH] D51559: [LLD][COFF] Cleanup error messages / add more coverage tests

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/PDB.cpp:168
   /// Cached to prevent repeated load attempts.
-  std::set<GUID> MissingTypeServerPDBs;
+  std::map<GUID, std::string> MissingTypeServerPDBs;
 };
----------------
We generally don't use std::map because it's slower than llvm::DenseMap and in most cases we don't need an ordered map (std::map is ordered). But this use may be okay because original code uses std::set. Or, we don't need to care about it at all if the number of data inserted into this map/set is small. Zach?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51559