[PATCH] D47858: [New PM] Introducing PassInstrumentation framework

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added inline comments.


================
Comment at: include/llvm/IR/PassManager.h:709
+  PassInstrumentation<IRUnitT>
+  getPassInstrumentation(IRUnitT &IR, std::tuple<ArgTs...> Args,
+                         llvm::index_sequence<Ns...>) {
----------------
fedor.sergeev wrote:
> philip.pfaffe wrote:
> > Are you ever actually calling this, except through the indirection above?
> Any suggestions on how to simplify it?
> This unpacker thing is the only way I figured to get Ns == sizeof(ExtraArgTs) and not sizeof(ArgTs).
You can do Ns == sizeof...(ExtraArgTs), but you're not actually using that here?


Repository:
  rL LLVM

https://reviews.llvm.org/D47858