[PATCH] D47858: [New PM] Introducing PassInstrumentation framework

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

In https://reviews.llvm.org/D47858#1221932, @philip.pfaffe wrote:

> IMO passing void* as an opaque ID along with the name is fine. Passing the PassConcept by reference ~~would degrade layering, since it lives in IR, not in Passes like the rest of this.~~ could be a viable alternative, the Passes library depends on IR anyways.


Yes, idea is to use void* of the PassConcept as an opaque ID.
Actually I plan to hide it under struct PassInstanceID, and its implementation can choose other ways of hiding this (e.g using unique string or whatnot).


Repository:
  rL LLVM

https://reviews.llvm.org/D47858