[PATCH] D51542: [X86] Remove wrong ReadAdvance from multiclass sse_fp_unop_s

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 3 06:34:55 PDT 2018


andreadb added a comment.

In https://reviews.llvm.org/D51542#1221947, @andreadb wrote:

> In https://reviews.llvm.org/D51542#1221933, @RKSimon wrote:
>
> > There seems to be 2 things here - (1) ReadAfterLd is being used incorrectly to try to make a dependency on the dst reg and (2) we have no mechanism to handle partial dependencies like for the scalar sse instructions.
> >
> > AFAICT this patch fixes the (1) issue but (2) isn't handled at all by the scheduler models yet.
>
>
> Yep.
>
> I will raise a bug for 2. This patch only addresses the issue with ReadAfterLd being incorrectly applied to a register used as the base address of the folded load.


Raised bug https://bugs.llvm.org/show_bug.cgi?id=38813.


https://reviews.llvm.org/D51542





More information about the llvm-commits mailing list