[PATCH] D51537: Extend hasStoreToStackSlot with list of FI accesses.

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 3 06:28:08 PDT 2018


thegameg added a comment.

I did a quick experiment to avoid storing the FrameIndex and get rid of the `FrameAccess` struct, by using this:

  const PseudoSourceValue *PSV = MMO->getPseudoValue();
  assert(PSV);
  const FixedStackPseudoSourceValue *FSPSV = dyn_cast<FixedStackPseudoSourceValue>(PSV);
  assert(FSPSV);
  return FSPSV->getFrameIndex();

to get the FI, and tests seem to pass.

Although this works, I am wondering how much we can rely on this working properly. Any thoughts?


Repository:
  rL LLVM

https://reviews.llvm.org/D51537





More information about the llvm-commits mailing list