[PATCH] D51571: [Xray] Darwin providing defined value for weak symbols to fix linkage issue
Dean Michael Berris via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Sep 2 07:08:41 PDT 2018
dberris added a reviewer: kubamracek.
dberris added a comment.
Does this actually do the right thing?
The patching routines need access to these symbols to determine where the instrumentation points are. If they're not present, that's how the runtime knows it's not supposed to patch the instrumentation sleds.
Can you share what the errors you're encountering are?
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D51571
More information about the llvm-commits
mailing list