[llvm] r341244 - lit: Use sys.executable for executing builtin commands

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 16:13:25 PDT 2018


On 08/31/2018 01:15 PM, Tom Stellard via llvm-commits wrote:
> Author: tstellar
> Date: Fri Aug 31 13:15:31 2018
> New Revision: 341244
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=341244&view=rev
> Log:
> lit: Use sys.executable for executing builtin commands
> 
> Summary:
> The python executable may not exist on all systems so use sys.executable
> instead.
> 

Hi Hans,

Is it OK to merge to the release_70 branch.  It fixes lit's builtin commands
and a few lit tests on systems where /usr/bin/python does not exist.

-Tom

> Reviewers: ddunbar, stella.stamenova
> 
> Subscribers: delcypher, llvm-commits
> 
> Differential Revision: https://reviews.llvm.org/D51511
> 
> Modified:
>     llvm/trunk/utils/lit/lit/TestRunner.py
> 
> Modified: llvm/trunk/utils/lit/lit/TestRunner.py
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=341244&r1=341243&r2=341244&view=diff
> ==============================================================================
> --- llvm/trunk/utils/lit/lit/TestRunner.py (original)
> +++ llvm/trunk/utils/lit/lit/TestRunner.py Fri Aug 31 13:15:31 2018
> @@ -879,7 +879,7 @@ def _executeShCmd(cmd, shenv, results, t
>          # Expand all glob expressions
>          args = expand_glob_expressions(args, cmd_shenv.cwd)
>          if is_builtin_cmd:
> -            args.insert(0, "python")
> +            args.insert(0, sys.executable)
>              args[1] = os.path.join(builtin_commands_dir ,args[1] + ".py")
>  
>          # On Windows, do our own command line quoting for better compatibility
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 



More information about the llvm-commits mailing list