[llvm] r341237 - [XRay] Improve test matching granularity (NFC)

[Dean Michael Berris via llvm-commits]

Author: dberris
Date: Fri Aug 31 11:56:42 2018
New Revision: 341237

URL: http://llvm.org/viewvc/llvm-project?rev=341237&view=rev
Log:
[XRay] Improve test matching granularity (NFC)

Simplify matchers for unittest to better isolate which differences there
are that we're finding in failures.

Modified:
    llvm/trunk/unittests/XRay/FDRTraceWriterTest.cpp

Modified: llvm/trunk/unittests/XRay/FDRTraceWriterTest.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/XRay/FDRTraceWriterTest.cpp?rev=341237&r1=341236&r2=341237&view=diff
==============================================================================
--- llvm/trunk/unittests/XRay/FDRTraceWriterTest.cpp (original)
+++ llvm/trunk/unittests/XRay/FDRTraceWriterTest.cpp Fri Aug 31 11:56:42 2018
@@ -63,16 +63,17 @@ TEST(FDRTraceWriterTest, WriteToStringBu
   auto &Trace = TraceOrErr.get();
 
   ASSERT_THAT(Trace, Not(IsEmpty()));
-  ASSERT_THAT(
-      Trace,
-      ElementsAre(AllOf(Field(&XRayRecord::FuncId, Eq(1)),
-                        Field(&XRayRecord::TId, Eq(1u)),
-                        Field(&XRayRecord::CPU, Eq(1u)),
-                        Field(&XRayRecord::Type, Eq(RecordTypes::ENTER))),
-                  AllOf(Field(&XRayRecord::FuncId, Eq(1)),
-                        Field(&XRayRecord::TId, Eq(1u)),
-                        Field(&XRayRecord::CPU, Eq(1u)),
-                        Field(&XRayRecord::Type, Eq(RecordTypes::EXIT)))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::FuncId, Eq(1)),
+                                 Field(&XRayRecord::FuncId, Eq(1))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::TId, Eq(1u)),
+                                 Field(&XRayRecord::TId, Eq(1u))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::PId, Eq(1u)),
+                                 Field(&XRayRecord::PId, Eq(1u))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::CPU, Eq(1u)),
+                                 Field(&XRayRecord::CPU, Eq(1u))));
+  ASSERT_THAT(Trace,
+              ElementsAre(Field(&XRayRecord::Type, Eq(RecordTypes::ENTER)),
+                          Field(&XRayRecord::Type, Eq(RecordTypes::EXIT))));
 }
 
 // This version is almost exactly the same as above, except writing version 2
@@ -107,16 +108,15 @@ TEST(FDRTraceWriterTest, WriteToStringBu
   auto &Trace = TraceOrErr.get();
 
   ASSERT_THAT(Trace, Not(IsEmpty()));
-  ASSERT_THAT(
-      Trace,
-      ElementsAre(AllOf(Field(&XRayRecord::FuncId, Eq(1)),
-                        Field(&XRayRecord::TId, Eq(1u)),
-                        Field(&XRayRecord::CPU, Eq(1u)),
-                        Field(&XRayRecord::Type, Eq(RecordTypes::ENTER))),
-                  AllOf(Field(&XRayRecord::FuncId, Eq(1)),
-                        Field(&XRayRecord::TId, Eq(1u)),
-                        Field(&XRayRecord::CPU, Eq(1u)),
-                        Field(&XRayRecord::Type, Eq(RecordTypes::EXIT)))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::FuncId, Eq(1)),
+                                 Field(&XRayRecord::FuncId, Eq(1))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::TId, Eq(1u)),
+                                 Field(&XRayRecord::TId, Eq(1u))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::CPU, Eq(1u)),
+                                 Field(&XRayRecord::CPU, Eq(1u))));
+  ASSERT_THAT(Trace,
+              ElementsAre(Field(&XRayRecord::Type, Eq(RecordTypes::ENTER)),
+                          Field(&XRayRecord::Type, Eq(RecordTypes::EXIT))));
 }
 
 // This covers version 1 of the log, without a BufferExtents record but has an
@@ -167,16 +167,16 @@ TEST(FDRTraceWriterTest, WriteToStringBu
   auto &Trace = TraceOrErr.get();
 
   ASSERT_THAT(Trace, Not(IsEmpty()));
-  ASSERT_THAT(
-      Trace,
-      ElementsAre(AllOf(Field(&XRayRecord::FuncId, Eq(1)),
-                        Field(&XRayRecord::TId, Eq(1u)),
-                        Field(&XRayRecord::CPU, Eq(1u)),
-                        Field(&XRayRecord::Type, Eq(RecordTypes::ENTER))),
-                  AllOf(Field(&XRayRecord::FuncId, Eq(1)),
-                        Field(&XRayRecord::TId, Eq(1u)),
-                        Field(&XRayRecord::CPU, Eq(1u)),
-                        Field(&XRayRecord::Type, Eq(RecordTypes::EXIT)))));
+  ASSERT_THAT(Trace, Not(IsEmpty()));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::FuncId, Eq(1)),
+                                 Field(&XRayRecord::FuncId, Eq(1))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::TId, Eq(1u)),
+                                 Field(&XRayRecord::TId, Eq(1u))));
+  ASSERT_THAT(Trace, ElementsAre(Field(&XRayRecord::CPU, Eq(1u)),
+                                 Field(&XRayRecord::CPU, Eq(1u))));
+  ASSERT_THAT(Trace,
+              ElementsAre(Field(&XRayRecord::Type, Eq(RecordTypes::ENTER)),
+                          Field(&XRayRecord::Type, Eq(RecordTypes::EXIT))));
 }
 
 } // namespace