[PATCH] D51524: [ARM64] [Windows] Handle funclets

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 10:43:30 PDT 2018


mgrang added inline comments.


================
Comment at: test/CodeGen/AArch64/wineh-funclets.ll:1
+; RUN: llc -o - %s -mtriple=aarch64-windows -stop-after=prologepilog | FileCheck %s
+; This test case just checks that we can get past catchret, etc, and not the
----------------
ssijaric wrote:
> mgrang wrote:
> > Check 80 char limits here.
> Is the 80 char limit on the RUN line a rule?  If so, many test cases don't follow this.  A single RUN is not split into multiple lines from what I've seen.
< many test cases don't follow this.
They should! 80 chars is what the LLVM coding standards recommend:
https://llvm.org/docs/CodingStandards.html#source-code-formatting
```
Write your code to fit within 80 columns of text. This helps those of us who like to print out code and look at your code in an xterm without resizing it.
```

Plus, horizontal scrolling is no fun :)



Repository:
  rL LLVM

https://reviews.llvm.org/D51524





More information about the llvm-commits mailing list