[PATCH] D51538: Add glibc_prereq to platform limits mmsghdr

Stephen Hines via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 10:37:05 PDT 2018


srhines added a comment.

Please upload patches with context, as it makes it easier to review. https://llvm.org/docs/Phabricator.html has instructions on how to do this (search for "context").



================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.cc:1044
+
+#if SANITIZER_LINUX && (!defined(__ANDROID__) || __ANDROID_API__ >= 21) && __GLIBC_PREREQ (2, 14)
 CHECK_TYPE_SIZE(mmsghdr);
----------------
I think this will break for Android, which doesn't define GLIBC_PREREQ. You need to put this check in with the `!defined(__ANDROID__)` part.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51538





More information about the llvm-commits mailing list