[PATCH] D51362: [GlobalISel][IRTranslator] Canonicalize G_ICMP to have constant operands last

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet added a comment.

> So overall I think we should have some form of IR canonicalization before translation for the majority of cases to be handled for -O0.



> If the legalizer or combiner is causing issues with introducing non-canonical forms then I think we should either fix them, or if that's not feasible, we accept the worse codegen at -O0 and introduce re-canonicalization either through MIRBuilder or a separate pass when optimizations are enabled.

Agreed.


Repository:
  rL LLVM

https://reviews.llvm.org/D51362