[PATCH] D41574: [Transforms] Adding a WeakReassociate pass

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Some remarks:

1. It currently runs *after* instcombine. Is that intentional? Didn't you say it is a preparation pass?
2. `local_unnamed_addr` and `#0` in tests isn't needed.
3. Please run `-instnamer` on the tests, i.e. `s/%/%t/` (name all variables.).
4. It is not ideal to test anything more than just the `-weak-reassociate` in the `test/Transforms/WeakReassociate/` (i.e. would be best to drop `-instcombine` from run lines)


Repository:
  rL LLVM

https://reviews.llvm.org/D41574