[PATCH] D51255: [WWW] Use https instead of http to fix page problems

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 03:47:57 PDT 2018


jdoerfert added a comment.

In https://reviews.llvm.org/D51255#1217833, @sqlbyme wrote:

> First off, thanks for offering to help make the website work correctly!  This all looks pretty reasonable to me.  I'm wondering though, would it be possible to break this patch up into a few smaller patches?  Since we do not have any type of staging infrastructure for llvm.org, I would prefer we not change so many files all at once.  I feel like three steps here might be appropriate:
>
> 1. Try with one file (one of the files with a one or two line change) to ensure the changes work as we expect them to.
> 2. Apply changes to the rest of the files with the exception of footer.incl.
> 3. Apply the last patch to footer.incl which adds the javascript bits in the footer (my experience tells me this is the most likely to break something, though the JS you have provided LGTM).


Sounds good, so let's do this step by step. [I started already since nobody found a general problem with the proposed changes.]

First some localized "absolute -> relative link" adjustments:
r341195. changed foundation/index.html to use relative links. It works for me and I'm waiting to see if it doesn't for anybody else.
r341196. changed a small part of the EuroLLVM 2017 dev meeting page. This helped, but this page is not completely working because the embedded js constructs a new css address (I think). I'm looking into this.

I'll wait a bit and if nobody complains I'll continue with the relative link adjustment. Then I'll update the patch again
and we can begin phase two.


https://reviews.llvm.org/D51255





More information about the llvm-commits mailing list