[PATCH] D50783: [CodeGen] Merge identical block descriptor global variables

David Chisnall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 03:41:32 PDT 2018


theraven added inline comments.


================
Comment at: lib/CodeGen/CGBlocks.cpp:163
+  std::string TypeAtEncoding =
+      CGM.getContext().getObjCEncodingForBlock(BlockInfo.getBlockExpr());
+  Name += "e" + llvm::to_string(TypeAtEncoding.size()) + "_" + TypeAtEncoding;
----------------
Specifically, this line.  It is unsafe to use an Objective-C encoding directly as a symbol name on ELF.


Repository:
  rC Clang

https://reviews.llvm.org/D50783





More information about the llvm-commits mailing list