[PATCH] D51289: [XRay] FDR Record Producer/Consumer Implementation

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/trunk/lib/XRay/FDRRecordProducer.cpp:50
+      MetadataRecordKinds::Pid,
+  };
+  switch (Mapping[T]) {
----------------
@dberris  Why are you mapping an integer to an enum with the same value?!? Replace the uint8_t T arg with an MetadataRecordKinds enum arg, or just get rid of the enum (AFAICT its only used in this function) and use the uint8_t directly.


Repository:
  rL LLVM

https://reviews.llvm.org/D51289