[llvm] r341177 - [MinGW] [X86] Pass true for the second parameter to StubValueTy for MO_COFFSTUB. NFC.

Martin Storsjo via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 31 01:00:31 PDT 2018


Author: mstorsjo
Date: Fri Aug 31 01:00:31 2018
New Revision: 341177

URL: http://llvm.org/viewvc/llvm-project?rev=341177&view=rev
Log:
[MinGW] [X86] Pass true for the second parameter to StubValueTy for MO_COFFSTUB. NFC.

These stubs should never be emitted for internal symbols, and
nothing in AsmPrinter ever actually use this value when producing
the stubs for COFF anyway.

Modified:
    llvm/trunk/lib/Target/X86/X86MCInstLower.cpp

Modified: llvm/trunk/lib/Target/X86/X86MCInstLower.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86MCInstLower.cpp?rev=341177&r1=341176&r2=341177&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86MCInstLower.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86MCInstLower.cpp Fri Aug 31 01:00:31 2018
@@ -170,8 +170,7 @@ MCSymbol *X86MCInstLower::GetSymbolFromO
     if (!StubSym.getPointer()) {
       assert(MO.isGlobal() && "Extern symbol not handled yet");
       StubSym = MachineModuleInfoImpl::StubValueTy(
-          AsmPrinter.getSymbol(MO.getGlobal()),
-          !MO.getGlobal()->hasInternalLinkage());
+          AsmPrinter.getSymbol(MO.getGlobal()), true);
     }
     break;
   }




More information about the llvm-commits mailing list