[PATCH] D50222: [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case)

[Dmytro Shynkevych via Phabricator via llvm-commits]

hermord updated this revision to Diff 163461.
hermord added a comment.

Comments addressed. The `minsize` condition needs some tweaking, it seems: the code with it works out to actually be longer on X86. Perhaps there should really be something like `isIntDivShort`.

Re: `test1`, by it being broken I only mean that it doesn't pass: it's not a miscompilation, just a less optimal output than desired.


Repository:
  rL LLVM

https://reviews.llvm.org/D50222

Files:
  include/llvm/CodeGen/TargetLowering.h
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  test/CodeGen/X86/jump_sign.ll
  test/CodeGen/X86/urem-seteq-optsize.ll
  test/CodeGen/X86/urem-seteq.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50222.163461.patch
Type: text/x-patch
Size: 14923 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180831/200c1a2c/attachment.bin>