[PATCH] D51522: [LLVM-C] Add more debug information accessors to GlobalObject and Instruction

whitequark via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 17:07:28 PDT 2018


whitequark added a comment.

How is a user of this API supposed to map the `unsigned Kind` values to something meaningful? We don't have an `enum LLVMMetadataKind`, do we?



================
Comment at: include/llvm-c/Core.h:2150
+ */
+void LLVMGlobalClearMetadata(LLVMValueRef Glob);
+
----------------
Very small nit: `Global`. There's some code out there that generates a higher level API by parsing the C headers and inferring semantics from names, let's keep it easy to maintain.


Repository:
  rL LLVM

https://reviews.llvm.org/D51522





More information about the llvm-commits mailing list