[PATCH] D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC).

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 163449.
wolfgangp added a comment.

When we find an error during table extraction, ListTableBase::extract is expected to set Offset to either 0 if the error is not recoverable, or to past the end of the table if it is. This removes the need to access the extracted length in the caller in the error case and simplifies recovery.

@vleschuk: Let me know what you think about this. I understand your suggestion but this seems a bit simpler to me.


https://reviews.llvm.org/D51081

Files:
  include/llvm/DebugInfo/DWARF/DWARFContext.h
  include/llvm/DebugInfo/DWARF/DWARFDebugRangeList.h
  include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h
  include/llvm/DebugInfo/DWARF/DWARFListTable.h
  include/llvm/DebugInfo/DWARF/DWARFUnit.h
  lib/DebugInfo/DWARF/CMakeLists.txt
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFDebugRangeList.cpp
  lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp
  lib/DebugInfo/DWARF/DWARFDie.cpp
  lib/DebugInfo/DWARF/DWARFListTable.cpp
  lib/DebugInfo/DWARF/DWARFUnit.cpp
  test/DebugInfo/Generic/cu-ranges.ll
  test/DebugInfo/Inputs/gmlt.ll
  test/DebugInfo/X86/dwarfdump-ranges-baseaddr.s
  test/DebugInfo/X86/dwarfdump-ranges-unrelocated.s
  test/DebugInfo/dwarfdump-ranges.test
  test/MC/ARM/dwarf-asm-multiple-sections.s
  tools/dsymutil/DwarfLinker.cpp
  tools/dsymutil/DwarfStreamer.cpp
  tools/dsymutil/DwarfStreamer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51081.163449.patch
Type: text/x-patch
Size: 61663 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180830/a2fada8c/attachment.bin>