[PATCH] D51450: [MinGW] [ARM] Add stubs for potential automatic dllimported variables
Reid Kleckner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 30 14:32:54 PDT 2018
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, regardless of what we do with the external linkage bit.
================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:840
+ StubSym = MachineModuleInfoImpl::StubValueTy(getSymbol(GV),
+ !GV->hasInternalLinkage());
+ }
----------------
Maybe we should just pass `true` here instead of `!GV->hasInternalLinkage()`. We should never use .refptr stubs to access internal symbols, right? They will always be DSO local, and should be accessible with other means.
We don't even use `Stub.second.getInt()` in the generic AsmPrinter.cpp code that emits the stub globals.
Repository:
rL LLVM
https://reviews.llvm.org/D51450
More information about the llvm-commits
mailing list