[PATCH] D47858: [New PM] Introducing PassInstrumentation framework

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

One additional implication on design that I just realized:

-pass-times functionality effectively requires to differentiate between distinct Pass instances, separately tracking times for different instances of the same "pass type".
That in turn requires passing some unique identifier for the pass instance, not just  for the pass type as I was doing before.

And that means there should be extra parameter to all the pass callbacks taking either pointer to pass (void*???) or some encoded version of that (unique string etc).
Perhaps it should be part of PassExecutionCounter (which actually becomes PassExecutionID and include both "execution counter" and "pass instance ID").


Repository:
  rL LLVM

https://reviews.llvm.org/D47858