[PATCH] D51048: cmake: Specify reference outputs in llvm_test_data()

Pankaj via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 11:42:31 PDT 2018


proton added a comment.

After applying this patch, the tests fail for me because it is taking the hash of stdout instead of the file mentioned in **llvm_test_verify_hash_program_output** macro. 
Changing line 64 of `cmake/modules/SingleMultiSource.cmake` to **${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${file}** will fix this.

Using  **llvm_test_verify(WORKDIR ${CMAKE_CURRENT_BINARY_DIR}** after **llvm_test_verify_hash_program_output** is redundant as it is already called in **llvm_test_verify_hash_program_output**.

I think it might be better if **llvm_test_verify_hash_program_output** supports multiple files at a time as it will decrease the length of cmake files (cmake files of Blur, Dither, and Interpolation have multiple reference files and other benchmarks might also have multiple reference files (if not now maybe in future)).



================
Comment at: cmake/modules/SingleMultiSource.cmake:64
+  llvm_test_verify(WORKDIR ${CMAKE_CURRENT_BINARY_DIR}
+    ${CMAKE_SOURCE_DIR}/HashProgramOutput.sh %o
+  )
----------------
${CMAKE_SOURCE_DIR}/HashProgramOutput.sh ${file}


Repository:
  rT test-suite

https://reviews.llvm.org/D51048





More information about the llvm-commits mailing list