[PATCH] D51317: Keep BumpPtrAllocator::Allocate(0) from returning nullptr

Jordan Rose via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 10:35:32 PDT 2018


jordan_rose added a comment.

>> If we do take this answer, we should *still* go to all clients and see if a zero-length check makes sense. "Copying" an empty string or empty array should definitely not result in an allocation.
>  In that case, should we just assert about it in the allocator?

I'm happy with that, but that's a heck of a breaking change for a low-level LLVM API.


Repository:
  rL LLVM

https://reviews.llvm.org/D51317





More information about the llvm-commits mailing list