[PATCH] D48792: [ARM] Set execute-only flags in .text.

[Ivan Lozano via Phabricator via llvm-commits]

ivanlozano added a comment.

In https://reviews.llvm.org/D48792#1219092, @peter.smith wrote:

> Thanks for the update. I still think this looks good to me.
>
> I'm out of quick ideas for how to do this in a better way. The only other ways that I can think of are to not pre-create the .text section and create in on demand if needed; or find some way of deleting it afterwards. These may be possible but will be more disruptive. I think that this will handle the LTO case where the "link-step" clang invocation doesn't get passed the -fexecute-only flag, which IIRC was the main reason not to just create the TextSection with the execute-only flag in the first place based on the presence of -fexecute-only.


Thanks!  Yea ideally I'd like to avoid this being a more disruptive change than it needs to be; not pre-creating the .text section seems like a heavier lift that may warrant it's own patch (or set of patches) from someone more well versed in this code.


https://reviews.llvm.org/D48792