[PATCH] D51161: Allow inconsistent offsets for 'noreturn' basic blocks when '-verify-cfiinstrs'

[Vladimir Stefanovic via Phabricator via llvm-commits]

vstefanovic marked 2 inline comments as done.
vstefanovic added inline comments.


================
Comment at: lib/CodeGen/CFIInstrInserter.cpp:320
           SuccMBBInfo.IncomingCFARegister != CurrMBBInfo.OutgoingCFARegister) {
+        // Inconsistent offsets/registers are ok for 'noreturn' blocks.
+        if (SuccMBBInfo.MBB->succ_empty() && !SuccMBBInfo.MBB->isReturnBlock())
----------------
thegameg wrote:
> Do you think we should add `because we don't generate epilogues inside noreturn blocks` to the comment? It might make it clearer on why the inconsistency is ok.
Makes sense.


Repository:
  rL LLVM

https://reviews.llvm.org/D51161