[PATCH] D51462: [ARM] Enable GEP offset splitting for 32-bit ARM.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 30 09:30:11 PDT 2018


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Yeah, I agree. Looks like it really helps out thumb1 code, and the code in CGP looks generic enough, not aarch64 specific.

LGTM



================
Comment at: test/Transforms/CodeGenPrepare/ARM/large-offset-gep.ll:19
+while_body:
+; CHECK:     str      r{{[0-9]+}}, [r{{[0-9]+}}, #4]
+  %i = add i32 %phi, 1
----------------
Any particular reason not to test both stores?


Repository:
  rL LLVM

https://reviews.llvm.org/D51462





More information about the llvm-commits mailing list