[PATCH] D51454: [LLD] [COFF] Make sections with runtime pseudo relocations writable

Thu Aug 30 00:21:32 PDT 2018

mstorsjo abandoned this revision.
mstorsjo added a comment.

In https://reviews.llvm.org/D51454#1218718, @mstorsjo wrote:

> In https://reviews.llvm.org/D51454#1218384, @smeenai wrote:
>
> > You can still use VirtualProtectFromApp with UWP; you just can't do W+X.
>
>
> Oh, I'll look into that. As long as all references from code use refptr, that should be fine then, and we could drop this patch.

Let's skip this patch, at least for now. VirtualProtectFromApp isn't available for Win8.x Store Apps though, but I don't know if that really is an issue for anybody.

What we could add, though, is a warning if there are runtime pseudo relocs in executable sections.

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D51454