[lld] r341016 - [test] Adjust a test to use CHECK-NEXT instead of CHECK-NOT. NFC.

Martin Storsjo via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 22:44:36 PDT 2018


Author: mstorsjo
Date: Wed Aug 29 22:44:36 2018
New Revision: 341016

URL: http://llvm.org/viewvc/llvm-project?rev=341016&view=rev
Log:
[test] Adjust a test to use CHECK-NEXT instead of CHECK-NOT. NFC.

Since the order and placement of the non-wanted elements might not
be obvious, it feels more straightforward to hardcode the whole list
with -NEXT elements (and checking for the end of the output with
CHECK-EMPTY) instead of adding CHECK-NOT lines at the right places
where the unwanted elements would appear if they erroneously
were to included.

Modified:
    lld/trunk/test/COFF/export-all.s

Modified: lld/trunk/test/COFF/export-all.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/COFF/export-all.s?rev=341016&r1=341015&r2=341016&view=diff
==============================================================================
--- lld/trunk/test/COFF/export-all.s (original)
+++ lld/trunk/test/COFF/export-all.s Wed Aug 29 22:44:36 2018
@@ -3,14 +3,13 @@
 # RUN: llvm-mc -triple=i686-windows-gnu %s -filetype=obj -o %t.obj
 
 # RUN: lld-link -lldmingw -dll -out:%t.dll -entry:DllMainCRTStartup at 12 %t.obj -implib:%t.lib
-# RUN: llvm-readobj -coff-exports %t.dll | FileCheck %s
+# RUN: llvm-readobj -coff-exports %t.dll | grep Name: | FileCheck %s
 # RUN: llvm-readobj %t.lib | FileCheck -check-prefix=IMPLIB %s
 
-# CHECK-NOT: Name: DllMainCRTStartup
-# CHECK-NOT: Name: _imp__unexported
-# CHECK: Name: dataSym
-# CHECK: Name: foobar
-# CHECK-NOT: Name: unexported
+# CHECK: Name:
+# CHECK-NEXT: Name: dataSym
+# CHECK-NEXT: Name: foobar
+# CHECK-EMPTY:
 
 # IMPLIB: Symbol: __imp__dataSym
 # IMPLIB-NOT: Symbol: _dataSym




More information about the llvm-commits mailing list