[PATCH] D51472: [ARM] Fix correctness checks in promoteToConstantPool.

[Eli Friedman via Phabricator via llvm-commits]

efriedma created this revision.
efriedma added reviewers: olista01, joerg.
Herald added a reviewer: javed.absar.
Herald added subscribers: chrib, kristof.beyls.

Correctly check for relocations in the constant to promote. And don't allow promoting a constant multiple times.

This partially fixes https://bugs.llvm.org/show_bug.cgi?id=32780 ; it's not a complete fix because we also need to prevent ARMConstantIslands from cloning the constant.

(-arm-promote-constant is currently off by default, and it stays off with this patch. I'll look into turning it on again when all the known issues are fixed.)


Repository:
  rL LLVM

https://reviews.llvm.org/D51472

Files:
  lib/Target/ARM/ARMISelLowering.cpp
  test/CodeGen/ARM/constantpool-promote-dbg.ll
  test/CodeGen/ARM/constantpool-promote.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51472.163249.patch
Type: text/x-patch
Size: 9354 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180830/b5361446/attachment.bin>