[llvm] r341000 - [MS Demangler] Fix several crashes and demangling bugs.

[Zachary Turner via llvm-commits]

Yes, we now use a larger buffer. But on second thought it’s still a fixed
size buffer, so although no existing compiler will ever generate a symbol
that could crash it anymore, a fuzzer could. I’ll fix it even better
tomorrow
On Wed, Aug 29, 2018 at 5:23 PM Friedman, Eli <efriedma at codeaurora.org>
wrote:

> On 8/29/2018 4:56 PM, Zachary Turner via llvm-commits wrote:
> >    * Account for "incorrect" string literal demanglings.  Apparently
> >      an older version of clang would not truncate mangled string
> >      literals to 32 bytes of encoded character data.  The demangling
> >      code however would allocate a 32 byte buffer thinking that it
> >      would not encounter more than this, and overrun the buffer.
> >      We now demangle up to 128 bytes of data, since the buggy
> >      clang would encode up to 32 *characters* of data.
>
> It sounds like this was this a crash?  If so, did you fix the crash?
>
> -Eli
>
> --
> Employee of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux
> Foundation Collaborative Project
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180829/b16db1a6/attachment.html>