[PATCH] D46204: [PPC64] V2 abi: Emit plt call stubs to the text section rather then the plt section.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 29 17:28:53 PDT 2018
MaskRay added inline comments.
================
Comment at: lld/trunk/ELF/InputSection.cpp:746
+ if (Rel.Sym->NeedsTocRestore) {
+ if (BufLoc + 8 > BufEnd || read32(BufLoc + 4) != 0x60000000) {
+ error(getErrorLocation(BufLoc) + "call lacks nop, can't restore toc");
----------------
If the file was compiled with `gcc -Bsymbolic -fPIC`, there may not be a `nop` after `bl`.
If the symbol also requires a PLT (its `NeedsTocRestore` will be true), this check will fail.
Repository:
rL LLVM
https://reviews.llvm.org/D46204
More information about the llvm-commits
mailing list