[PATCH] D51399: [Xray] Darwin improving slightly the support

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 17:13:01 PDT 2018


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM -- Thanks!

In https://reviews.llvm.org/D51399#1216969, @devnexen wrote:

> In https://reviews.llvm.org/D51399#1216936, @dberris wrote:
>
> > Can you describe what the issue with `xray_init` is? Or is it because we're not setting the `XRAY_NO_PREINIT` option in Darwin / macOS?
> >
> > There's a set of macro checks in `lib/xray/xray_init.cc` which determine whether or not we should be using `.preinit_array`.
>
>
> In fact more to try to fix undefined reference (xray_init.cc was not added to files to compile).


Ah, okay.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D51399





More information about the llvm-commits mailing list