[PATCH] D51460: [WebAssembly] Be a little more conservative in WebAssemblyFixFunctionBitcasts
Jacob Gravelle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 29 16:16:09 PDT 2018
jgravelle-google accepted this revision.
jgravelle-google added a comment.
This revision is now accepted and ready to land.
The change feels a bit screwy to me, but I can't think of any alternative ways to factor this that aren't worse.
================
Comment at: test/CodeGen/WebAssembly/function-bitcasts.ll:23
; CHECK-NEXT: call .Lhas_i32_ret_bitcast at FUNCTION{{$}}
+; CHECK-NEXT: i32.call $drop=, has_i32_ret at FUNCTION
; CHECK-NEXT: i32.const $push[[L0:[0-9]+]]=, 0
----------------
One too many spaces after call?
Repository:
rL LLVM
https://reviews.llvm.org/D51460
More information about the llvm-commits
mailing list