[PATCH] D51459: [WebAssembly][WIP] Vector conversions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 15:09:05 PDT 2018


aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:569
+  if (WasmDisableExplicitLocals)
+    return Def;
+
----------------
tlively wrote:
> @aardappel This solution for the problem described in the comment fixes my own test, but causes crashes in the stackification tests. I assume this function is doing other work besides creating a TEE that cannot be skipped. Could you suggest a more robust way to fix this problem?
(We talked in person and I'm gonna summarize it here)
Giving those instructions fake opcodes (like 0) can be one solution too.


Repository:
  rL LLVM

https://reviews.llvm.org/D51459





More information about the llvm-commits mailing list