[PATCH] D51452: [MinGW] [AArch64] Add stubs for potential automatic dllimported variables

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64Subtarget.cpp:204
+           !GV->isDSOLocal() && GV->isDeclarationForLinker() &&
+           isa<GlobalVariable>(GV))
+    Flags = AArch64II::MO_COFFSTUB | AArch64II::MO_GOT;
----------------
I don't see why it matters whether the value is a GlobalVariable, specifically, as opposed to an alias or function.

I don't see why this applies specifically to MinGW, as opposed to all Windows targets.

I'm not sure what the point of the isDeclarationForLinker check is... it seems redundant with the isDSOLocal check.


Repository:
  rL LLVM

https://reviews.llvm.org/D51452