[PATCH] D51207: Introduce llvm.experimental.widenable_condition intrinsic

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

The code looks fine.
I see that all your tests have empty deopt bundles.
Wouldnt it make sense to add something there, just in case?



================
Comment at: include/llvm/IR/Intrinsics.td:833
 
+// Supports widenable conditions for explicitly expressed guards.
+def int_experimental_widenable_condition : Intrinsic<[llvm_i1_ty], [],
----------------
for guards represented as explicit branches


================
Comment at: include/llvm/Transforms/Scalar/ExplicifyGuards.h:1
+//===--- ExplicifyGuards.h - Turn guard intinrics into guard branches -----===//
+//
----------------
"intinrics" -> intrinsics


https://reviews.llvm.org/D51207