[PATCH] D50634: [RISCV] Add support for local PIC addressing

Sameer AbuAsal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 12:19:10 PDT 2018


sabuasal added inline comments.


================
Comment at: lib/Target/RISCV/RISCVISelLowering.cpp:609
+
+  // Fold the offset to the load/stores so we can save the ADDI above.
+  SmallPtrSet<MachineInstr *, 2> FoldOffsetInstrs;
----------------
We already have a peephole optimization, and a machine function pass (D47857), that do this. are you sure we need this?


https://reviews.llvm.org/D50634





More information about the llvm-commits mailing list