[PATCH] D51415: [SimpleLoopUnswitch] After unswitch delete dead blocks in parent loops

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 11:00:56 PDT 2018


asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

This LGTM.
FWIW, I think we're having an underlying problem and this and the previous PRs may be related.
In unswitchTrivialSwitch, at the very beginning we're removing switch cases and querying LoopInfo to get the outer loop for each switch successor without updating it. LoopInfo is updated only at the very end in hoistLoopToNewParent. Adding an artificial assert to check if LI should be updated after removing switch cases, triggers on 2/3 tests from https://reviews.llvm.org/D51375 and existing trivial-unswitch tests. Looking into it further.


Repository:
  rL LLVM

https://reviews.llvm.org/D51415





More information about the llvm-commits mailing list