[PATCH] D51362: [GlobalISel][IRTranslator] Canonicalize G_ICMP to have constant operands last

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 29 08:44:42 PDT 2018


qcolombet added a comment.

I agree with the motivation but I don’t think this is the right approach. I would prefer we run a canonicalization step even at O0 before GISel rather than duplicating this logic between IR and MI.
Jump tables are a different beast and have their place in here because they don’t really make sense to do on IR.

What I am saying is code duplication is bad :)


Repository:
  rL LLVM

https://reviews.llvm.org/D51362





More information about the llvm-commits mailing list