[PATCH] D50591: [PGO] Control Height Reduction
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 29 08:39:20 PDT 2018
davidxl added inline comments.
================
Comment at: lib/Transforms/Instrumentation/ControlHeightReduction.cpp:1808
+ assert(Bias >= getCHRBiasThreshold() && "Must be highly biased");
+ CHRBranchBias *= Bias;
+ BasicBlock *IfThen = BI->getSuccessor(1);
----------------
This might be too conservative that the merged branch becomes less biased as it can be. It is very likely that the contributing branches are correlated. How about taking the 'min' BranchProb as the resulting BP?
Repository:
rL LLVM
https://reviews.llvm.org/D50591
More information about the llvm-commits
mailing list